Daft icon indicating copy to clipboard operation
Daft copied to clipboard

[FEAT] add register-table helper to sql-catalog

Open chuanlei-coding opened this issue 1 year ago • 3 comments

chuanlei-coding avatar Sep 12 '24 02:09 chuanlei-coding

CodSpeed Performance Report

Merging #2837 will degrade performances by 13.97%

Comparing chuanlei-coding:feat-add-register-table-helper-to-sqlcatalog (5858396) with main (6d30e30)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chuanlei-coding:feat-add-register-table-helper-to-sqlcatalog Change
test_count[1 Small File] 3.6 ms 4.2 ms -13.97%
test_iter_rows_first_row[100 Small Files] 340.5 ms 299.1 ms +13.83%
test_show[100 Small Files] 34.9 ms 24.8 ms +40.79%

codspeed-hq[bot] avatar Sep 12 '24 02:09 codspeed-hq[bot]

Hi, what's the intended use-case/ticket that this would address?

cc @universalmind303 as well who is designing the overall story for SQL

jaychia avatar Sep 15 '24 21:09 jaychia

@jaychia @universalmind303 so we can sql query dataframe on the fly.

chuanlei-coding avatar Sep 18 '24 06:09 chuanlei-coding

Sorry @chuanlei-coding, It appears I overlooked this PR. if you want to fix the merge conflicts, I think we could get this in!

universalmind303 avatar Nov 22 '24 22:11 universalmind303

Sorry @chuanlei-coding, It appears I overlooked this PR. if you want to fix the merge conflicts, I think we could get this in!

@universalmind303 conflict fixed. Could you please have a look again?

chuanlei-coding avatar Dec 04 '24 13:12 chuanlei-coding

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (6d30e30) to head (5858396). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
daft/sql/sql.py 50.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2837      +/-   ##
==========================================
+ Coverage   77.00%   77.32%   +0.31%     
==========================================
  Files         696      696              
  Lines       86039    84738    -1301     
==========================================
- Hits        66256    65522     -734     
+ Misses      19783    19216     -567     
Files with missing lines Coverage Δ
daft/sql/sql.py 95.45% <50.00%> (-2.17%) :arrow_down:

... and 11 files with indirect coverage changes

codecov[bot] avatar Dec 04 '24 13:12 codecov[bot]