Daft icon indicating copy to clipboard operation
Daft copied to clipboard

[FEAT] Add a `list.contains` API

Open raunakab opened this issue 1 year ago • 1 comments

Overview

Added a list.contains API to check whether or not a column of type List or FixedSizeList contains a given value.

raunakab avatar Aug 31 '24 01:08 raunakab

CodSpeed Performance Report

Merging #2773 will degrade performances by 27.25%

Comparing ronnie/list-contains (d63ce68) with main (d9d916b)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ronnie/list-contains Change
test_iter_rows_first_row[100 Small Files] 184.3 ms 253.3 ms -27.25%

codspeed-hq[bot] avatar Aug 31 '24 01:08 codspeed-hq[bot]

@raunakab @kevinzwang status on this PR?

samster25 avatar Oct 30 '24 23:10 samster25

Hey folks, status? @raunakab

jaychia avatar Nov 20 '24 17:11 jaychia

Codecov Report

Attention: Patch coverage is 2.46914% with 79 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (5fee192) to head (d63ce68). Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-functions/src/list/contains.rs 0.00% 48 Missing :warning:
src/daft-core/src/array/ops/list.rs 0.00% 16 Missing :warning:
src/daft-core/src/series/ops/list.rs 0.00% 14 Missing :warning:
daft/expressions/expressions.py 50.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
- Coverage   77.41%   77.35%   -0.07%     
==========================================
  Files         678      679       +1     
  Lines       83680    83332     -348     
==========================================
- Hits        64783    64460     -323     
+ Misses      18897    18872      -25     
Files with missing lines Coverage Δ
src/daft-functions/src/list/mod.rs 100.00% <100.00%> (ø)
daft/expressions/expressions.py 93.26% <50.00%> (-0.12%) :arrow_down:
src/daft-core/src/series/ops/list.rs 58.55% <0.00%> (-5.95%) :arrow_down:
src/daft-core/src/array/ops/list.rs 92.39% <0.00%> (-2.14%) :arrow_down:
src/daft-functions/src/list/contains.rs 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

codecov[bot] avatar Nov 21 '24 00:11 codecov[bot]

This is a stale PR. Closing in favour of https://github.com/Eventual-Inc/Daft/pull/3479.

raunakab avatar Dec 03 '24 16:12 raunakab