Daft icon indicating copy to clipboard operation
Daft copied to clipboard
verified publisher icon Eventual-Inc

[FEAT]: Improve dt.hour() expression

Open zacharyftw opened this issue 1 year ago • 3 comments

Improve dt.hour() expression https://github.com/Eventual-Inc/Daft/issues/2086

Complete Implementation done

zacharyftw avatar Apr 09 '24 17:04 zacharyftw

Hi @KekmaTime is this PR ready to review? Also we should add some tests in this file to ensure that this works for time64: https://github.com/Eventual-Inc/Daft/blob/0fe3df72081b64516649047fbb4b5145ee65d76e/tests/series/test_temporal_ops.py#L109

samster25 avatar Apr 15 '24 22:04 samster25

Hi @KekmaTime is this PR ready to review? Also we should add some tests in this file to ensure that this works for time64:

https://github.com/Eventual-Inc/Daft/blob/0fe3df72081b64516649047fbb4b5145ee65d76e/tests/series/test_temporal_ops.py#L109

alright ill get into it!

zacharyftw avatar Apr 17 '24 19:04 zacharyftw

@colin-ho did you think you can help out here and write some tests for this PR?

samster25 avatar May 08 '24 23:05 samster25