Daft icon indicating copy to clipboard operation
Daft copied to clipboard

Add Expressions from Ibis

Open jaychia opened this issue 1 year ago • 6 comments

Is your feature request related to a problem? Please describe.

We would like to add more expressions and kernels for functionality to eventually have parity with Ibis (https://ibis-project.org/reference/expression-numeric).

Generic

https://ibis-project.org/reference/expression-generic

  • [ ] #1903
  • [x] #1904
  • [ ] #1905

Numeric

https://ibis-project.org/reference/expression-numeric

  • [x] #2103
  • [x] #1906
  • [x] #2102
  • [x] #1867
  • [ ] #1907
  • [x] #1908
  • [x] #1909
  • [x] #1910
  • [x] #1911
  • [ ] #1912
  • [x] #1913
  • [x] #1914
  • [x] #1915
  • [x] #1916
  • [x] #1917
  • [x] #1918

Strings

Single-argument kernels:

  • [x] #1919
  • [x] #1920
  • [x] #1921
  • [x] #1922
  • [x] #1923
  • [x] #1924

Multi-argument kernels:

  • [x] #1925
  • [x] #1926
  • [x] #1927
  • [ ] #1928
  • [ ] #1929
  • [x] #1930
  • [x] #1931
  • [x] #1932
  • [x] #1933
  • [ ] #1934
  • [x] #2074

jaychia avatar Jun 12 '23 20:06 jaychia

Taking care of this issue.

shril avatar Jun 13 '23 06:06 shril

Thanks @NormallyGaussian for ceil #1867 !

jaychia avatar Feb 12 '24 18:02 jaychia

Would like to take care of a few of these as an intro to this repo !

nsalerni avatar Feb 20 '24 04:02 nsalerni

Would like to take care of a few of these as an intro to this repo !

Yes, some of the string functionality should be a pretty good introduction! Just make sure to comment in this PR which functions you are taking to avoid duplicate with :)

Here's a really awesome PR to show you how to get started: https://github.com/Eventual-Inc/Daft/pull/1867

jaychia avatar Feb 20 '24 17:02 jaychia

Thanks @jaychia ! I will take the single-argument string kernels to start:

  • .str.capitalize()
  • .str.upper()
  • .str.lower()
  • .str.lstrip()
  • .str.rstrip()
  • .str.reverse()

nsalerni avatar Feb 20 '24 18:02 nsalerni

Exploded all the checkboxes into individual issues so they can be assigned and tracked better.

colin-ho avatar Feb 20 '24 20:02 colin-ho