EventStore.JVM icon indicating copy to clipboard operation
EventStore.JVM copied to clipboard

Allow manual ack and nack to take multiple messages

Open ghostbuster91 opened this issue 4 years ago • 0 comments

Currently messages for manual ack and nack in PersistentSubscriptionActor are defined as follows:

  final case class ManualAck(eventId: Uuid)
  final case class ManualNak(eventId: Uuid)

While the underlying api allows to pass there multiple events id:

    case Event(PSA.ManualAck(eventId), details: PSA.SubscriptionDetails) =>
      toConnection(Ack(details.subscriptionId, eventId :: Nil))
      stay
    case Event(PSA.ManualNak(eventId), details: PSA.SubscriptionDetails) =>
      toConnection(Nak(details.subscriptionId, List(eventId), Retry, None))
      stay
  }

Is there any valid reason why options to pass lists isn't exposed?

ghostbuster91 avatar Jul 30 '20 10:07 ghostbuster91