ClientAPI.NetCore
ClientAPI.NetCore copied to clipboard
Fix ExpectedVersion
EmptyStream is 0, add missing Invalid
Isn´t the stream version zero based? Why change -1 to 0?
@Narvalex Thanks for your question. You can see the comment here: https://github.com/EventStore/ClientAPI.NetCore/blob/master/src/EventStore.ClientAPI.NetCore/ExpectedVersion.cs#L13 which obviously claims something different then the code, and second, you can check the server implementation here: https://github.com/EventStore/EventStore/blob/master/src/EventStore.Core/Data/ExpectedVersion.cs On the other hand, at the server side this value is commented out, see https://github.com/EventStore/EventStore/blob/master/src/EventStore.Core/Data/ExpectedVersion.cs#L7.
You are right, @prolic ! thanks for your kind response. I didn't see that the NoStream constant (-1) is still there. I was worry it will break my event sourcing framework library.