LaravelEventSauce icon indicating copy to clipboard operation
LaravelEventSauce copied to clipboard

Fix message storage of recorded at for mysql 8.0

Open Robertbaelde opened this issue 2 years ago • 3 comments

This small change in the LaravelMessageRepository will fix the issue with mysql8 datetime:

Issue in LaravelEventSauce https://github.com/EventSaucePHP/LaravelEventSauce/issues/25 "parent" issue in EventSauce: https://github.com/EventSaucePHP/EventSauce/issues/108

I'm aware of the MySQL8DateFormatting but I think formatting the date in the right way for the storage should be a concern of the repository.

Besides that, I think this would improve the onboarding experience of new users of this package.

Robertbaelde avatar Jan 20 '22 20:01 Robertbaelde

@frankdejonge @rahmanii0 Curious about the vision you both have in regards to the versioning of this package. Since EventSauce .8 to 1.2 introduced some breaking changes, I think it would be easier for maintenance of this package to follow EventSauce's major version bump.

If we don't do this, we'll end up with If checks through this package in order to support all versions. Happy with both ways, but think it's a nice time to discuss since this PR encountered the issue.

Robertbaelde avatar Jan 20 '22 20:01 Robertbaelde

@Robertbaelde I think it makes sense to drop 0.8 and bump the major version up.

frankdejonge avatar Jan 22 '22 09:01 frankdejonge

Do we still need to do this if we replace LaravelMessageRepository with the core Illuminate message repository? #35

simensen avatar Apr 08 '22 22:04 simensen