reamberPy icon indicating copy to clipboard operation
reamberPy copied to clipboard

Scale Full LN gaps w.r.t. current BPM

Open Bestfast opened this issue 2 years ago • 2 comments

As the title suggests, in my opinion having it set to a dataframe would make the algorithm more flexible for chart generation and make FLN only a small piece of a chart. At the moment, the full LN algorithm uses a dataframe anyway for its operation, so I think it should be just a couple of lines to change it. Reference: https://github.com/Eve-ning/reamberPy/blob/e03d9454ee15b4904633a1acc87a36b415a95105/reamber/algorithms/generate/full_ln.py#L24

main focus of this would be making custom algorithms based on full LN possible eg: having the gap set to a 1/4 of the current BPM of the chart, thing that is not possible (without having a lot of writes and splitting the chart for every bpm change) for multi-bpm charts.

Bestfast avatar Feb 26 '23 08:02 Bestfast

Hello, thanks for suggesting. I originally made the full_ln signature only accept a Map to keep it clear on what's the expected input. I think having a DataFrame can be confusing as there's many ways to construct a DF from a Map.

Let me know a simple use-case and I'll see if I have any alternative solutions to it

Eve-ning avatar Feb 26 '23 08:02 Eve-ning

Updated the title to make it a higher level use-case

Eve-ning avatar Feb 26 '23 08:02 Eve-ning