node-unzip icon indicating copy to clipboard operation
node-unzip copied to clipboard

Fix bug in archives with uncompressed files

Open glebdmitriew opened this issue 10 years ago • 9 comments

This pull request fixes unzipping for uncompressed files which size is not known in the header. This fixes issues: #41, #32 and may fix #56 and #52.

glebdmitriew avatar Sep 26 '14 12:09 glebdmitriew

This is amazing @glebdmitriew and fixes the numerous reported 'Error: invalid signature' issues.

Can we please get this merged upstream @EvanOxfeld?

missinglink avatar Oct 28 '14 18:10 missinglink

:+1: This is awesome, also fixes #63. Great find @missinglink! The PR would probably need some work regarding README and package.json changes, from the looks of it.

silverwind avatar Oct 28 '14 18:10 silverwind

Will this get merged eventually?

pietercolpaert avatar Nov 25 '14 15:11 pietercolpaert

I would really love if this was merged. It basically saved my project!

mbatista avatar Dec 04 '14 06:12 mbatista

FYI to anyone using this fork of the module, you will need to change your code due to this commit which landed a few days ago https://github.com/glebdmitriew/node-unzip-2/commit/10c0c2953d98be7e9db930aa9b5dd285c2bdbc06 or you will get Error: Invalid Package: expected node-unzip-2 but found unzip errors from fresh installs.

The change is pretty simple and should look something like this: https://github.com/geopipes/geonames-stream/pull/8/files

If you are currently linking to the github tarball you can test if you have this issue by executing npm install, no error, no problem ;)

missinglink avatar Dec 09 '14 18:12 missinglink

Maybe someone should start a clean fork :innocent:

silverwind avatar Dec 09 '14 23:12 silverwind

@glebdmitriew : can you push your version on npm as unzip2 ? Since this package looks dead it would be cool…

qraynaud avatar Dec 10 '14 13:12 qraynaud

We added the unzip2 as npm package npm install unzip2

https://www.npmjs.com/package/unzip2

seagullua avatar Dec 10 '14 18:12 seagullua

Yes http://github.com/glebdmitriew/node-unzip-2 can resolve the problem.

Oneway102 avatar Sep 09 '15 02:09 Oneway102