node-unzip
node-unzip copied to clipboard
Fix bug in archives with uncompressed files
This pull request fixes unzipping for uncompressed files which size is not known in the header. This fixes issues: #41, #32 and may fix #56 and #52.
This is amazing @glebdmitriew and fixes the numerous reported 'Error: invalid signature' issues.
Can we please get this merged upstream @EvanOxfeld?
:+1: This is awesome, also fixes #63. Great find @missinglink! The PR would probably need some work regarding README and package.json changes, from the looks of it.
Will this get merged eventually?
I would really love if this was merged. It basically saved my project!
FYI to anyone using this fork of the module, you will need to change your code due to this commit which landed a few days ago https://github.com/glebdmitriew/node-unzip-2/commit/10c0c2953d98be7e9db930aa9b5dd285c2bdbc06 or you will get Error: Invalid Package: expected node-unzip-2 but found unzip
errors from fresh installs.
The change is pretty simple and should look something like this: https://github.com/geopipes/geonames-stream/pull/8/files
If you are currently linking to the github tarball you can test if you have this issue by executing npm install
, no error, no problem ;)
Maybe someone should start a clean fork :innocent:
@glebdmitriew : can you push your version on npm as unzip2 ? Since this package looks dead it would be cool…
We added the unzip2 as npm package
npm install unzip2
https://www.npmjs.com/package/unzip2
Yes http://github.com/glebdmitriew/node-unzip-2 can resolve the problem.