node-unzip icon indicating copy to clipboard operation
node-unzip copied to clipboard

DO NOT USE THIS THING

Open mmontag opened this issue 6 years ago • 8 comments

Just a warning to amplify the sentiments of others here and on StackOverflow.

See https://stackoverflow.com/a/46967462/264970

mmontag avatar Sep 27 '18 01:09 mmontag

If you have already written code against unzip and are having problems, try https://www.npmjs.com/package/unzipper, which should be a drop-in replacement. Worked for me.

mmontag avatar Sep 27 '18 18:09 mmontag

whoa, lost a few hours trying to figure out why it was not working for my use case, and it really looked like it wasn't consuming my stream properly. thanks for the reminder :)

nicolas-cherel avatar Oct 01 '18 15:10 nicolas-cherel

Fantastic! I've spent almost a day to find the problem in my code, but the problem was in that lib.

grigorkin avatar Oct 03 '18 06:10 grigorkin

@mmontag thank you so much for this thread. I did spent hours with issues with this package and unzipper did work as a drop-in replacement without any issues inside modern async code! Thank you so much!

kalinchernev avatar Oct 08 '18 11:10 kalinchernev

Wooh. Thanks!

shaunwarman avatar Dec 06 '18 18:12 shaunwarman

Wow, thanks for this issue. I've been tracing weird file behavior for hours. Couldn't figure out why intermittently I couldn't overwrite a file that had been unzipped. Following this post I think it couldn't overwrite the file because it's file handle was probably still in use.

Thanks a ton @mmontag

Gi60s avatar Jan 11 '19 00:01 Gi60s

Thanks, @mmontag! After spending a day writing code that uses this it's fantastic to have a drop-in replacement.

IanDavey avatar Jan 16 '19 21:01 IanDavey

@EvanOxfeld I hope you are alive. Could you please mark this package as deprecated? It will help to make NodeJS ecosystem less cluttered.

dobromyslov avatar Feb 01 '21 19:02 dobromyslov