DropHeads icon indicating copy to clipboard operation
DropHeads copied to clipboard
verified publisher icon EvModder

3.10.5.1 reports itself as 3.10.5 and always tries to update (to the same version)

Open kribjo opened this issue 4 months ago • 2 comments

I believe that DropHeads v3.10.5.1 erroneously reports itself as v3.10.5 and because of this also tries to update despite there being no newer version available.

Steps to reproduce:

  1. Download DropHeads.jar v3.10.5.1 from https://dev.bukkit.org/projects/dropheads/files
  2. Put the jar in plugins or plugins/update directory
  3. Start/restart server

What happens: DropHeads reports itself as v3.10.5. When checking for updates it finds a v3.10.5.1 available and downloads it and puts it in plugins/update.

What is expected: DropHeads to report itself as v3.10.5.1 and not trying to update to the same version.

Setup:

[bootstrap] Running Java 21 (OpenJDK 64-Bit Server VM 21.0.2+13-LTS; Amazon.com Inc. Corretto-21.0.2.13.1) on Windows Server 2019 10.0 (amd64)
[bootstrap] Loading Paper 1.21.8-39-main@616a879 (2025-08-18T02:25:55Z) for Minecraft 1.21.8
> version
This server is running Paper version 1.21.8-39-main@616a879 (2025-08-18T02:25:55Z) (Implementing API version 1.21.8-R0.1-SNAPSHOT)
You are running the latest version
> version dropheads
DropHeads version 3.10.5
Heads for every mob and player.
Website: https://dev.bukkit.org/projects/dropheads
Author: EvModder

Log excerpt:

[09:07:31 INFO]: [DropHeads] Enabling DropHeads v3.10.5
[09:07:31 INFO]: [DropHeads] Version update: 3.10.5 -> 3.10.5.1
[09:07:32 INFO]: [DropHeads] About to download a new update: DropHeads v3.10.5.1
[09:07:32 INFO]: [DropHeads] Downloading update: 0% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 0% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 0% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 0% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 0% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 10% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 10% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 10% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 10% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 10% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 20% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 20% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 20% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 20% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 20% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 30% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 30% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 30% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 30% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 30% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 40% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 40% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 40% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 40% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 40% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 40% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 50% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 50% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 50% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 50% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 50% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 60% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 60% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 60% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 60% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 60% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 60% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 70% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 70% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 70% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 70% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 70% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 70% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 80% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 80% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 80% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 80% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 80% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 80% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 90% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 90% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 90% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 90% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 90% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Downloading update: 100% of 541509 bytes.
[09:07:32 INFO]: [DropHeads] Finished updating.

kribjo avatar Aug 18 '25 07:08 kribjo

Oh yeah I was noticing this before too, it's from a bug in the Updater library the plugin uses.

It's really quite annoying, the only work-around currently is to disable auto-update. I'll see if I can fix it in the next release (shouldn't be too hard)

EvModder avatar Aug 30 '25 10:08 EvModder

It's taken me a bit but I've circled back around to this and done a full rewrite of the Updater. Since it wasn't my own code, it's always been something I've wanted to take a look at and see if I could improve, and omg yes, it is much cleaner now (less code, faster code, and most importantly it won't generate that junk "update" folder in your server plugin folder anymore, thank god).

It'll be in the next release, which should be out later this month🤞 (dev jar already available).

EvModder avatar Sep 10 '25 04:09 EvModder