HoneySelectVR icon indicating copy to clipboard operation
HoneySelectVR copied to clipboard

voices are not working correctly in vr mode with new dlc

Open theboobness opened this issue 7 years ago • 11 comments

Hi Eusth, the voices aren't working correctly when I go in an H scene. there would be multiple voices (4 or more) playing at the same time. In normal mode without vr, the game plays fine. Is there any way to fix this?

theboobness avatar Apr 30 '17 02:04 theboobness

Completely untested, but try this: HoneySelectVR_0.6.1.zip

Eusth avatar Apr 30 '17 09:04 Eusth

Thank you!! it works perfectly now!!

theboobness avatar Apr 30 '17 15:04 theboobness

I posted this to the honeyselect subreddit so more VR users can test. https://www.reddit.com/r/HoneySelect/comments/6930pt/anyone_able_to_get_vr_working_with_the_party_dlc/

As always, thank you Eusth for your huge contribution to VR

plasticfant avatar May 11 '17 15:05 plasticfant

@Eusth Could you please tell what did you patched? I use custom HoneySelect plugin built from sources, and it seems that these changes are not published on Github...

deinlandel avatar May 21 '17 13:05 deinlandel

Yup, because it breaks the positional audio. Not gonna add the "fix" to the code. Simply remove the VoiceShim line in HoneySelectVR.cs.

Eusth avatar May 21 '17 23:05 Eusth

Thank you so much for this Eusth! Working great!

Devilsbane99 avatar Jun 11 '17 09:06 Devilsbane99

Thanks this the sound is working right now.

ice36bc avatar Jul 20 '17 10:07 ice36bc

Thanks for update = v =

gzhuji avatar Jul 24 '17 08:07 gzhuji

Does that mean there is no working positional audio for 1.20? Also my folder does not contain a HoneySelect.cs file. When using VR patch 0.6 there is also no positional audio unless it's used on version 1.1 for me.

plasmacut avatar Jul 13 '18 17:07 plasmacut

The reason positional audio doesn't work in 1.20 is because a new bool force2D parameter was added to the Play and OnecePlayChara methods in Manager.Voice. For whatever reason, OnecePlayChara is called with this set to true during H-scenes.

I managed to fix this in a quick & dirty way (see my fork), but:

  1. I decided to use Harmony for runtime patching (just to learn it).
  2. I always set force2D to false.

ZerothAngel avatar Jun 05 '19 01:06 ZerothAngel

nice work!

DragonQuestHero avatar Oct 23 '20 08:10 DragonQuestHero