Oghenovo Usiwoma

I tested this locally and I've observed that the test doesn't fail if you modify the external wallet's timelocks, see below: `external = multisig.getdescriptorinfo(f"wsh(thresh({self.N},pk({f'),s:pk('.join(external_xpubs)}),sln:after(128)))")` The reason is that the test...

Tested ACK https://github.com/bitcoin/bitcoin/pull/28336/commits/98570fe29bb08d7edc48011aa6b9731c6ab4ed2e Verified that all checks are covered in tests

Tested ACK [d9df438](https://github.com/bitcoin/bitcoin/pull/29179/commits/d9df438c6e581dae0c818a4c2f5fe95627ae26bc) Ran the tests locally and got `test_framework.authproxy.JSONRPCException: Invalid or non-wallet transaction id (-5)` for both `wallet_import_rescan.py` and `wallet_rescan_unconfirmed.py` when insertion order is used in `CTxMemPool::entryAll()`.

> might be worth to define all error codes (in a new enum) to allow for easy future mapping of them to a different or more verbose message (like this...

> The enum members don't need the `i32` fields, they will only every be set to one value define them like this: ` RpcInvalidRequest = -32600,` > > and the...

> the documentation of the error codes can also be copied from the header file of bitcoind source Are you referring to the comments in the protocol.h file? > i...

@antonilol Thanks for your help with the `macro_rules!` definition. I've changed the implementation to use that and I also added doc comments. Please take a look and let me know...

@antonilol I had to remove the `to_error_code` fn because it was never used and it caused the tests to fail

@romanz Is there anything else I need to address before this can be merged?

I'm working on a PR for this. The error, `"No such mempool transaction. Use -txindex or provide a block hash to enable blockchain transaction queries. Use gettransaction for wallet transactions."`...