magic-racket icon indicating copy to clipboard operation
magic-racket copied to clipboard

support define-syntax-parser builtin

Open dannypsnl opened this issue 3 years ago • 10 comments

dannypsnl avatar Sep 09 '21 15:09 dannypsnl

I'm not sure whether it makes sense, but in the past I generated the tmLanguage.json file from the .yaml file that's in syntaxes/src. We should discuss whether it makes sense to use the yaml file, because if it does, it would be better to make the changes there and then just generate the json file from it to keep them both in sync. What do you think?

Eugleo avatar Dec 26 '21 08:12 Eugleo

Yes, that also confuse me once I find out there has a YAML. I think if keep YAML, maybe should ignore JSON, and generate JSON on deployment. After some read, I think YAML looks easier for maintaining.

dannypsnl avatar Dec 26 '21 11:12 dannypsnl

And I also found some interesting: 圖片

there have duplicated define-syntax...

dannypsnl avatar Dec 26 '21 11:12 dannypsnl

Good point. Would you mind removing these duplicated values, and setting up the GitHub action to generate the json file automatically?

Eugleo avatar Dec 26 '21 11:12 Eugleo

Sure, whats your command for yaml to json?

dannypsnl avatar Dec 26 '21 12:12 dannypsnl

Probably some external tool; I did all of this such a long time ago that I unfortunately have no idea. We will need to find something suitable.

Eugleo avatar Dec 26 '21 12:12 Eugleo

Ok, maybe I also do some research about conversion tool.

dannypsnl avatar Dec 26 '21 15:12 dannypsnl

Actually, there about 1500 duplicates in that list image

shocoman avatar Jan 01 '22 08:01 shocoman

@Eugleo I finally find one, I think you might use https://github.com/pedro-w/vscode-tmlanguage

This plugin has a command Convert to tmLanguage JSON can be triggered via shift + command + p in vscode.

dannypsnl avatar Aug 28 '22 06:08 dannypsnl

  1. I want to rebuild YAML file from JSON since the current YAML file is actually invalid.
  2. Then merge these branch first for new keywords support(define-syntax-parser).
  3. And we have another PR for remove duplicates

dannypsnl avatar Aug 28 '22 06:08 dannypsnl