tabby icon indicating copy to clipboard operation
tabby copied to clipboard

Tab's close button doesn't get focus in full screen

Open shangyin2024 opened this issue 1 year ago • 0 comments

Version: 1.0.211 Platform: macOS arm64 24.0.0 Plugins: highlight Frontend: xterm-webgl

shangyin2024 avatar Aug 20 '24 03:08 shangyin2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 8:26pm
pipedream ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 8:26pm
pipedream-sdk-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 8:26pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
pipedream-docs ⬜️ Ignored (Inspect) Aug 27, 2024 8:26pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Aug 27, 2024 8:26pm

vercel[bot] avatar Aug 20 '24 05:08 vercel[bot]

Walkthrough

The recent updates enhance the GitHub webhook event handling by including important headers in emitted events, specifically X-GitHub-Event, X-GitHub-Delivery, and X-GitHub-Hook-ID. This enhancement improves tracking and debugging capabilities. Additionally, various components have undergone version increments, indicating minor improvements or bug fixes throughout the codebase.

Changes

File(s) Change Summary
components/github/package.json Updated package version from 1.2.1 to 1.3.0.
components/github/sources/* Added headers parameter in multiple methods (onWebhookTrigger, emitEvent, processEvent). Enhanced event emission to include github_headers using getRelevantHeaders.
components/github/sources/utils.mjs Introduced getRelevantHeaders utility function to extract GitHub-related headers from incoming requests.
components/github/sources/webhook-events/webhook-events.mjs Enhanced event emission by merging relevant headers with the event body. Updated version from 1.0.3 to 1.0.4.
components/github/sources/new-commit/new-commit.mjs Updated version from 1.0.4 to 1.0.5 and modified onWebhookTrigger to destructure headers from the event.

Assessment against linked issues

Objective Addressed Explanation
Include additional GitHub headers for webhook events (#13580)
Create a github_headers object to encompass relevant headers (#13580)

🐇 In the meadow, hopping with glee,
New headers abound, as bright as can be!
With X-GitHub names, our events now shine,
Tracking and debugging, oh so divine!
Let's celebrate changes with a joyful cheer,
For every new feature brings us near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 20 '24 05:08 coderabbitai[bot]

/approve

GTFalcao avatar Aug 26 '24 03:08 GTFalcao

This has a conflict in an unrelated app file, likely from merging with master before - I'll need a new approval

GTFalcao avatar Aug 27 '24 20:08 GTFalcao

/approve

GTFalcao avatar Aug 27 '24 20:08 GTFalcao