tabby icon indicating copy to clipboard operation
tabby copied to clipboard

Fix Issue #8461: Add Toggle Hotkey and Pin Button for SFTP Panel

Open GeminiLn opened this issue 1 year ago • 4 comments

This PR addresses Issue #8461 by introducing two new features for the SFTP Panel:

  1. Toggle Hotkey:
  • Added a hotkey to toggle the visibility of the SFTP Panel, enhancing user convenience. Hotkey
  1. Pin Button:
  • Introduced a Pin button in the SFTP Panel. When activated, this button prevents the panel from closing when clicking outside of it, ensuring that the pinned panel remains open. Pin

GeminiLn avatar Jul 13 '24 00:07 GeminiLn

Thank you for contributing! In which case is it necessary to pin the panel?

Having to navigate to the current SFTP folder can be easily avoided by correctly setting up the CWD reporting, and the terminal in the background can't be currently properly used anyway while the panel is open.

Eugeny avatar Jul 15 '24 21:07 Eugeny

Thank you for contributing! In which case is it necessary to pin the panel?

Having to navigate to the current SFTP folder can be easily avoided by correctly setting up the CWD reporting, and the terminal in the background can't be currently properly used anyway while the panel is open.

Issue #8461 did not specify when it is necessary to pin the panel. In my experience, I sometimes accidentally click outside the panel, causing it to close, which is quite annoying. I think adding a pin feature can prevent this.

And yes, I do notice that the terminal is unusable when the panel is open. I’m curious if it’s possible to adjust the panel to allow terminal use alongside SFTP. If this adjustment is feasible, I’d be willing to work on it sometime.

GeminiLn avatar Jul 15 '24 21:07 GeminiLn

TBF I think that would be a more viable improvement, as I don't quite see what this PR is solving (it's trivial to reopen the panel after closing it).

That would involve converting the SFTPPanel component into an SFTPTab and changing the SFTP button logic to instead opening a split pane (same as the "split > bottom" menu item) that would host the new SFTP tab sharing the same connection profile.

Eugeny avatar Jul 16 '24 07:07 Eugeny

For my workflow it's incredibly annoying to not have a pinned sidebar, would be great to be able to have both the terminal and the sftp pinned somehow, though a hotkey to open it would be great until then

barrelltitor avatar Sep 22 '24 03:09 barrelltitor