tabby icon indicating copy to clipboard operation
tabby copied to clipboard

Search impact on copy paste

Open gitthangbaby opened this issue 1 year ago • 6 comments

Describe the problem: When search (CtrlShiftF) is open, clicking on the shell will copy the search keyword. Even when it's emptied.

To Reproduce: Open search window Type some text to search bar (if it's big enough, looks like it graphically overlaps with standard buttons) Click on the shell (not selecting) Paste ** Expected result: -> whatever was in clipboard should be pasted ** unexpected result: -> the search keyword is pasted Empty the search keyword Click on the shell (not selecting) Paste ** Expected result: -> whatever was in clipboard should be pasted ** unexpected result: -> the word "direct" is pasted

gitthangbaby avatar Nov 01 '23 17:11 gitthangbaby

Hi @gitthangbaby,

It looks very similar to an old issue that should be fixed now. Which version do you use?

Clem-Fern avatar Nov 01 '23 18:11 Clem-Fern

Hi @gitthangbaby,

Which version do you use?

It's 1.0.201.

Here the Win+V clipboard history shows how "direct" is inserted into clipboard everytime I come back to a session and copy something. Before each paste, I have to recall the previous item from history: image

Visually, can't press those 3 search buttons, because there are window buttons: image

gitthangbaby avatar Nov 01 '23 20:11 gitthangbaby

The same question. My version is 1.0.197, when I paste secondly, the word is the search keyword.

mysterin avatar Nov 15 '23 04:11 mysterin

I wasnt able to reproduce this :/

Did the Copy on Select option is enabled ? If so, could you disable it and try to reproduce this issue again ?

Clem-Fern avatar Nov 17 '23 08:11 Clem-Fern

On my side, can't reproduce with Copy on Select off because it's part of the steps to reproduce.

I thought running mc helps (lot of issues arise from that https://github.com/Eugeny/tabby/issues/8884#issuecomment-1754861840) to reproduce, but not needed in this case: better use a search keyword that is found on the screen. Like @mysterin said, double click a text, and right click twice. Second paste is the search string.

update: incredible but today Tabby was inserting the last searchword to my clipboard all day, replacing the copied record with its searchword. And today I didn't even use Tabby. The whole Windows-V history is full of reinserted searchword.

gitthangbaby avatar Nov 17 '23 20:11 gitthangbaby

Visually, can't press those 3 search buttons, because there are window buttons: image

visual overlap issue can be 'fixed' by moving the tab location to the top (Settings\Window\Tabs). the functional issue is reproduced from 197 to 207 on Windows & Linux. Can be mitigated by turning off Copy on Select (Terminal\Clipboard).

gitthangbaby avatar Feb 12 '24 00:02 gitthangbaby