visbrain icon indicating copy to clipboard operation
visbrain copied to clipboard

Fix MNE bdf/gdf EEG file imports

Open Teteros opened this issue 3 years ago • 2 comments

Importing .bdf and .gdf currently fails (NME 0.21.1) because those filetypes have their own importers. This change will make them work again in the Sleep GUI when chosen on open file.

Teteros avatar Nov 08 '20 00:11 Teteros

Hi @Teteros,

Thank you so much for the PR, and so sorry for the late reply...! The PR looks great. Questio: does that mean that Visbrain will require MNE>0.21.1?

Also worth noting, since MNE 0.22 there is a generic function (https://mne.tools/stable/generated/mne.io.read_raw.html#mne.io.read_raw) that automatically call the appropriate function based on the file extension. But I would prefer to keep compatibility with older versions of MNE for now (at least 0.21).

Thanks Raphael

raphaelvallat avatar Feb 17 '21 18:02 raphaelvallat

does that mean that Visbrain will require MNE>0.21.1?

The minimum version of MNE required for this change is 0.18 I believe https://github.com/mne-tools/mne-python/blob/main/doc/changes/0.18.inc#L258

as that's when the edf reader was split into BDF/GDF ones.

Teteros avatar Feb 21 '21 12:02 Teteros