EthicalSource
[FEATURE] Add responsive mobile nav
What does this PR accomplish?
- Resolves #146, plus cleans up some of the base template
Getting there
- Implemented a mobile nav utilizing css, following basic structure and in line with HTML5 specs
Deploy Preview for ethicalsource failed.
| Name | Link |
|---|---|
| Latest commit | 4edd2afe6b1520db8309439af2fb356d237075c6 |
| Latest deploy log | https://app.netlify.com/sites/ethicalsource/deploys/66fb2a156bcd420008615cb5 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for ethicalsource ready!
| Name | Link |
|---|---|
| Latest commit | c74318199bb3829ae897f13667ab2a1824d4d1db |
| Latest deploy log | https://app.netlify.com/sites/ethicalsource/deploys/6702d373225ca50008d7d169 |
| Deploy Preview | https://deploy-preview-148--ethicalsource.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Setting latest version of Hugo (v0.135.0) + Go (v1.23.1) in a netlify.toml file with https://github.com/EthicalSource/ethicalsource.dev/pull/148/commits/e4e3ceae49c2c6dec95e0f7fe7bce746de0e3dbf , which makes use of faster processing and how Hugo handles site variables. We are currently on Hugo v0.58.3 and Go 1.16.5.
Ok - so we have a working responsive, mobile nav bar
normal nav
mobile nav beginning at 768px
This looks great! A couple of notes:
- Can we shrink the hamburger menu graphic down, and make it a bit less chunky?
- Can we adjust the positioning of the hamburger menu so that it's snug in the upper right corner, with the same top and side margins as the logo?
- When the mobile nav pops up, should it cover the entire header area? Or the top? The placement doesn't quite feel right to me.
Sorry, I got buried under a bunch of other things. I have not forgotten this though, and will come back soon to finish up @CoralineAda .