EtherealEngine
IR-2012 Update file system operation to promise API (Partial)
Summary
Due the extensive use of file system operations I decided to approach this story by sending portions of each fs api migration with the objective of avoiding extensive and overwhelming code reviews as well as to reduce risk.
For this pull request I introduced writeFileAsync, existsAsync and deprecated deleteFolderRecursive.
I have completely replaced any writeFileSyncRecursive call for the new writeFileAsync. I have completely replaced any deleteFolderRecursive call for the native node.js api fps.rmdir(path, { recursive: true }) I have partially replaced some fs.existsSync calls for the new existsAsync function, will continue replacing these calls in subsequent PRs
Subtasks Checklist
[x] Implement non-blocking writeFileAsync helper [x] Implement non-blocking existsAsync helper [x] Implement non-blocking cpAsync helper [x] Replace deleteFolderRecursive helper in favour of native non-blocking fps.rmdir function
Breaking Changes
N/A
References
JIRA Ticket IR-2012
QA Steps
Already modified tests using new non-blocking APIs should still pass
npm run test
Thank you for your pull request and welcome to the Ethereal Engine developer community!
We require contributors to sign our Copyright Assignment Agreement, and we don't seem to have you on file.
In order for us to review and merge your code, please sign the agreement at https://forms.gle/15ENsSAJGKf2ozvB7
The agreement has not been signed by users: @jonathan-casarrubias.
After signing the agreement, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR :)
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for your pull request and welcome to the Ethereal Engine developer community!
We require contributors to sign our Copyright Assignment Agreement, and we don't seem to have you on file.
In order for us to review and merge your code, please sign the agreement at https://forms.gle/15ENsSAJGKf2ozvB7
The agreement has not been signed by users: @jonathan-casarrubias.
After signing the agreement, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR :)
Looking good now, I would like this QA'd on a deployment to make sure the builder and project installer works correctly
Looking good now, I would like this QA'd on a deployment to make sure the builder and project installer works correctly
Seemed to all work fine on QAT.
