OpenSesame icon indicating copy to clipboard operation
OpenSesame copied to clipboard

macOS requires manual iCloud group setting even though Info.plist autogenerates the correct one.

Open EthanLipnik opened this issue 3 years ago • 9 comments

image It seems that the only solution is to manually set the iCloud group. All the code should be working but for macOS it doesn't. Hopefully a new Xcode version will help. Opening an issue

Originally posted by @EthanLipnik in https://github.com/OpenSesameManager/OpenSesame/issues/25#issuecomment-917745550

EthanLipnik avatar Sep 13 '21 00:09 EthanLipnik

Seems to also effect iOS randomly

EthanLipnik avatar Sep 13 '21 00:09 EthanLipnik

I'm not seeing that issue (and I haven't whilst developing the PR)

Screen Shot 2021-09-12 at 10 32 23 PM

Note how it shows the $ at the end - indicating it came from the XCConfig

In the Apple dev account it shows the correct values

Screen Shot 2021-09-12 at 10 34 22 PM

What values are you seeing in the OpenSesameConfig.generated.swift file? Since I have to change all of the overrides to get it working in my dev account - I wonder if you're not overriding if one of the values isn't set.

I have

struct OpenSesameConfig { 
  fileprivate init() {}
    static let PRODUCT_BUNDLE_IDENTIFIER_BASE = "ca.shand.OpenSesame"
    static let TEAM_IDENTIFIER = "7GMH2FWQ44"
    static let APP_GROUP = "group.OpenSesame.shand"
}

feralbob avatar Sep 13 '21 01:09 feralbob

The values in the generated file are correct for me, the project won't update to them

EthanLipnik avatar Sep 13 '21 12:09 EthanLipnik

Might be worth double checking in the build settings that there isn't a hard coded value somewhere. The Mac client might still have hard coded values for PRODUCT_BUNDLE_IDENTIFIER for the release configuration.

Happy to try pairing sometime to see if we can work it out.

feralbob avatar Sep 13 '21 13:09 feralbob

image Not sure if it's related but I can't run Xcode Previews anymore. Works in the simulator

EthanLipnik avatar Sep 13 '21 15:09 EthanLipnik

image Just tried a fresh clone and the iCloud issue still remains. Might need to have the iCloud part hard coded until we figure out the automated part

EthanLipnik avatar Sep 15 '21 01:09 EthanLipnik

OK - let me upgrade to the latest RCs and I'll take another look.

feralbob avatar Sep 15 '21 22:09 feralbob

OK - let me upgrade to the latest RCs and I'll take another look.

/me twiddles thumbs as things download and install.

feralbob avatar Sep 18 '21 23:09 feralbob

I've been trying with the RC but can't seem to figure it out. Also effecting iOS now

EthanLipnik avatar Sep 18 '21 23:09 EthanLipnik