EternalCore icon indicating copy to clipboard operation
EternalCore copied to clipboard

[WIP] Make the plugin folia-compatible

Open vLuckyyy opened this issue 1 year ago • 3 comments

  • [ ] Teleports (homes, jail, warps)
  • [ ] Commands -> (/skull, /weather, /day, /night, /sudo, /time, /eternal reload)
  • [ ] CatBoy Feature

Summary by CodeRabbit

  • New Features

    • Updated version constants for improved compatibility.
    • Added support for a new Maven repository for dependency resolution.
    • Introduced support for Folia in the plugin configuration.
  • Enhancements

    • Command execution flow improved with the addition of a Scheduler dependency for various commands, allowing for asynchronous operations.
  • Bug Fixes

    • Corrected import statements in the SkullCommand class.
  • Chores

    • Updated dependency management in the build configuration.

vLuckyyy avatar Sep 14 '24 19:09 vLuckyyy

@coderabbitai full review

vLuckyyy avatar Oct 09 '24 17:10 vLuckyyy

:white_check_mark: Actions performed

Full review triggered.

coderabbitai[bot] avatar Oct 09 '24 17:10 coderabbitai[bot]

Walkthrough

The changes in this pull request involve updates to version constants, the addition of a new Maven repository, modifications to dependency declarations in the build.gradle.kts files, and enhancements to several command classes by introducing a Scheduler dependency. Additionally, the SchedulerSetup class has been updated to improve scheduler management, and the plugin configuration now indicates support for Folia.

Changes

File Path Change Summary
buildSrc/src/main/kotlin/Versions.kt Updated version constants: ETERNALCODE_COMMONS from "1.1.3" to "1.1.4-SNAPSHOT"; ADVENTURE_TEXT_MINIMESSAGE from "4.18.0-SNAPSHOT" to "4.17.0"
buildSrc/src/main/kotlin/eternalcore-repositories.gradle.kts Added new Maven repository URL: https://repo.eternalcode.pl/snapshots/
eternalcore-core/build.gradle.kts Added three implementation dependencies for eternalcode-commons-bukkit, eternalcode-commons-folia, and eternalcode-commons-adventure. Removed library declarations for eternalcode-commons-bukkit and eternalcode-commons-adventure from eternalShadow.
eternalcore-core/src/main/java/com/eternalcode/core/feature/essentials/item/SkullCommand.java Updated import statement for Command annotation.
eternalcore-core/src/main/java/com/eternalcode/core/feature/essentials/sudo/SudoCommand.java Constructor updated to include Scheduler dependency.
eternalcore-core/src/main/java/com/eternalcode/core/feature/essentials/time/DayCommand.java Constructor updated to include Scheduler dependency; setDay method modified to use scheduler.
eternalcore-core/src/main/java/com/eternalcode/core/feature/essentials/time/NightCommand.java Constructor updated to include Scheduler dependency; setNight method modified to use scheduler.
eternalcore-core/src/main/java/com/eternalcode/core/feature/essentials/time/TimeCommand.java Constructor updated to include Scheduler dependency; add and set methods modified to use scheduler.
eternalcore-core/src/main/java/com/eternalcode/core/feature/essentials/weather/RainCommand.java Constructor updated to include Scheduler dependency; setRain method modified to use scheduler.
eternalcore-core/src/main/java/com/eternalcode/core/feature/essentials/weather/SunCommand.java Constructor updated to include Scheduler dependency; setSun method modified to use scheduler.
eternalcore-core/src/main/java/com/eternalcode/core/feature/essentials/weather/ThunderCommand.java Constructor updated to include Scheduler dependency; setThunder method modified to use scheduler.
eternalcore-core/src/main/java/com/eternalcode/core/scheduler/SchedulerSetup.java Added constant FOLIA and replaced direct instantiation of BukkitSchedulerImpl with getAdaptiveScheduler method.
eternalcore-plugin/build.gradle.kts Added property foliaSupported in pluginYml configuration block.

Poem

In the fields where bunnies play,
New versions hop in bright array.
With schedulers now by our side,
Commands will run with joyful pride.
A repository, fresh and neat,
Makes our code a tasty treat! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 09 '24 17:10 coderabbitai[bot]