Traincraft-5 icon indicating copy to clipboard operation
Traincraft-5 copied to clipboard

[Enhancement] Add Fluids to Forge Liquid Dictionary

Open HadesDurin opened this issue 8 years ago • 1 comments

Add Diesel and Refined Fuel to Forge Liquid Dictionary. maybe also make refined Fuel equal to Buildcraft Fuel.

HadesDurin avatar Jun 01 '17 15:06 HadesDurin

according to the code they are already registered in forge's FluidDictionary. https://github.com/EternalBlueFlame/Traincraft-5/blob/1.7/src/main/java/train/common/api/LiquidManager.java#L56-L57

However The current system doesn't use classes to define the fluids, they are static variables, so we can't properly implement buildcraft's interfaces for fuel to the fluid objects. There is an attempt at it here, but clearly not a working one anymore due to the required implementations in their API: https://github.com/EternalBlueFlame/Traincraft-5/blob/1.7/src/main/java/train/common/api/LiquidManager.java#L77-L81

EternalBlueFlame avatar Jul 20 '18 00:07 EternalBlueFlame