Tourney icon indicating copy to clipboard operation
Tourney copied to clipboard

Quality assurance using Font Bakery

Open felipesanches opened this issue 4 years ago • 8 comments

Hello, Tyler,

My name is Felipe Sanches and I work on the development of Font Bakery, a quality assurance tool used by Google Fonts to ensure adherence to a set of criteria prior to publishing the font files to Google servers.

You can learn more about the tool at https://font-bakery.readthedocs.io/en/latest/ (we even have an introductory video there explaining the overall purpose of the project)

I would like to offer you help in setting up this font project repo (and maybe other repos as well) to run Font Bakery automatically at each new commit pushed to master branch. And then I'd like to show you the check results and see if there's anything unclear about them that we could improve in the tool, or any actual issues in the font project that we could fix to make it more likely to be added to the Google Fonts collection.

What do you think? I hope this is useful for you ;-)

cheers, Felipe

felipesanches avatar Apr 09 '20 01:04 felipesanches

Sounds good @felipesanches ! I've been running the variable files through http://fontbakery.graphicore.de periodically. Happy to tweak things on my end to make it as usable as possible.

sursly avatar Apr 09 '20 14:04 sursly

ah! That's good! That webapp tends to be in sync with the command line tool.

Are there check results that you do not understand? I'd be glad to help.

felipesanches avatar Apr 09 '20 14:04 felipesanches

I am getting some errors that I didn't used to (did my stuff already head to google fonts?). Here's the latest for one that I thought was almost in the clear (grandstander): https://fontbakery.graphicore.de/report/fdb52a58-c0b5-42cc-9b4f-53ef27121cb0

sursly avatar Apr 09 '20 19:04 sursly

OK, I see a few ERRORs in there. These are things that I have to fix. I'll try to understand what happened there.

To be clear, a FAIL is a problem with the font while an ERROR is a problem with the tool (Font Bakery itself seems broken in this case).

I will open new issues on the Font Bakery issue tracker at https://github.com/googlefonts/fontbakery/issues so that we don't forget to fix these problems. If you see anything that seems wrong, please don't think twice before reporting at our issue tracker ;-D

felipesanches avatar Apr 09 '20 19:04 felipesanches

Oh wow, that's good to know between Fail and Error (I had no clue). I'm tackling fails now...

sursly avatar Apr 09 '20 19:04 sursly

Question @felipesanches: I get the failure "com.google.fonts/check/repo/vf_has_static_fonts A static fonts directory with at least two fonts must accompany variable fonts "

But I'm just uploading one TTF VF file. Should I disregard this? I definitely have a static folder (and files) in my repo.

sursly avatar Apr 09 '20 23:04 sursly

Sorry, here is the link: https://fontbakery.graphicore.de/report/24c1095a-ca20-4b84-8918-e817449ae960

sursly avatar Apr 09 '20 23:04 sursly

You can disregard

davelab6 avatar Apr 11 '20 03:04 davelab6