Etar-Calendar icon indicating copy to clipboard operation
Etar-Calendar copied to clipboard

Widget doesn't change background color when system changes theme.

Open davidtakac opened this issue 3 years ago • 6 comments

Reproduce:

  1. Put widget on home screen
  2. Change from light to dark system theme (or vice versa) a couple of times

Expected:

  • Widget changes colors according to theme

Actual:

  • Only the edges of events respond to theme changes, but the widget background doesn't

Tested on:

  • Google Pixel 4a 5G, Android 11
  • Samsung Galaxy S8, Android 9
  • Nexus 5X Emulator Android 11

davidtakac avatar May 23 '21 21:05 davidtakac

Can you make a pull request with your fix or do you still want to test it?

Gitsaibot avatar May 28 '21 16:05 Gitsaibot

I still want to test it because I'm not sure if this is the most efficient way. I will make a PR when it's ready.

davidtakac avatar May 29 '21 08:05 davidtakac

Same Here

BAProductions avatar Oct 30 '21 16:10 BAProductions

Just tested your fix & it works 100% Tested on:

Samsung Galaxy Tab 4 10.1, Android 10/LOS 17.1/LFRQ Samsung Galaxy Tab 4 8.0, Android 10/LOS 17.1/LFRQ Samsung Galaxy Tab E 9.6 MSM8916, Android 10/LOS 17.1/LFRQ

BAProductions avatar Oct 30 '21 16:10 BAProductions

Hey, yeah, it fixes the problem, but it's really a workaround so I'm not that happy with it. It causes the widget to go through it's initialization process twice, which is inefficient.

The best and most "Android" solution would be to handle the theme change via themes, but the dark/black theme combination complicates things.

TL;DR: I'll look into a more robust and thorough solution soon.

davidtakac avatar Oct 30 '21 19:10 davidtakac

Any news? Is your fix doing anything on the widget header color? I'm confused that it is still blue with the black theme enabled while the rest of the app isn't.

new2f7 avatar Jan 09 '22 17:01 new2f7

Chipping in - the issue described still happens on etar versioin 13 on LOS 20.

dav23r avatar Apr 08 '23 19:04 dav23r