Event duplication

[jonas-haeusler]

testing and feedback is very welcome :-)

resolves #87, #666, #749.

the duplication option also provides a better workaround to move events between calendars.

i modified event_info_title_bar.xml a bit to make the top bar less cluttered by hiding items if android thinks there is not enough room for them, and by reordering the items by (my subjective) priority. let me know if this is not wanted.

[Gitsaibot]

Thank you for working on this. At the moment I have little time to test everything thoroughly. But since this feature was requested by many here, maybe a few testers can be found.

You can find the apk here: https://github.com/Etar-Group/Etar-Calendar/actions/runs/3285611169

[Gitsaibot]

i modified event_info_title_bar.xml a bit to make the top bar less cluttered by hiding items if android thinks there is not enough room for them, and by reordering the items by (my subjective) priority. let me know if this is not wanted.

In my opinion all icons should be visible except "SD card export". With your change only 2 icons are displayed although there would be room for more.

[jonas-haeusler]

With your change only 2 icons are displayed although there would be room for more.

this is done deliberateley to follow material design guidelines, see https://m3.material.io/components/top-app-bar/guidelines#224e8ca0-4177-45f4-9f4f-eef1fbb0e4b2.

When there are more than three interactive icons, the less important ones can be collapsed into an overflow menu. The overflow menu then takes the place of a third action.

in addition to that, when using app:showAsAction="always" the top app bar will not be displayed correctly on smaller screen sizes:

which is also stated by the android docs: https://developer.android.com/guide/topics/resources/menu-resource

android:showAsAction always Always place this item in the app bar. Avoid using this unless it's critical that the item always appear in the action bar. Setting multiple items to always appear as action items can result in them overlapping with other UI in the app bar.

let me know if you still think this is a bad change, then I'll revert it :)

[Gitsaibot]

I think nowadays the smaller screen sizes are the exception. I can remember discussions that revolved around the number of clicks until you got an entry deleted. With this it would be one more click ;)

In principle, I find a tidy bar also nicer but the icon for delete should always be visible. @jspricke What do you think?

[jspricke]

I would order them by priority and use ifRoom. My order would be:

• edit
• delete
• duplicate
• share
• export
• change_color

[dumblob]

I use smaller screens and agree with @jspricke's priority list (assuming most important thing at the top :wink:) under the condition that in case ifRoom will not show it, it will automatically appear in the hamburger menu.