Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard

Essentials signs do not support item metadata

Open devioursoul opened this issue 10 years ago • 8 comments

Hello,

I made a short video to explain my issue to prevent confusion.

https://www.youtube.com/watch?v=5zoFoWinco0

If you prefer not to watch it I will explain it here.

I am using the EssentialsX-2.0.1.jar plugin and Silkspawners(amongst a few others) 12345

When I use the [buy] sign to buy spawners with EssentialsX-2.0.1.jar in combination with silkspawners it works fine, and using the [sell] sign instantly after will sell it.

However.....

When placing the spawner and picking it up with a silktouch pickaxe, and than trying to sell it back I get the error "Error:You do not have 1x mobspawner"

I have read that multiple people / servers have this issue so I am not sure if it can be "fixed". but if anyone can do it it's going to be you guys :)

Of course if this is sorted I will make a small compensation for the support given.

devioursoul avatar Jul 08 '15 12:07 devioursoul

It's just walking, nothing more. It doesn't add anything to the video.

devioursoul avatar Jul 08 '15 22:07 devioursoul

any help would be appreciated.

devioursoul avatar Jul 12 '15 01:07 devioursoul

We currently don't support all the metadata in sell signs, only buy signs.

drtshock avatar Jul 13 '15 15:07 drtshock

Fair enough, thank you for responding. can I expect this in the future ?

Thx.

devioursoul avatar Jul 13 '15 16:07 devioursoul

Yes in the future.

drtshock avatar Jul 13 '15 16:07 drtshock

ok awesome, this can be closed than.

devioursoul avatar Jul 13 '15 16:07 devioursoul

No because it's not added yet :)

drtshock avatar Jul 13 '15 16:07 drtshock

Current pathways of implementation of this are as follows;

All versions - item name should have a asterisk next to it indicating that the item is not just the base item and has specific metadata attached to it. A new command like /signinfo with aliases of /(sell|trade|buy)info would give specific metadata information. We could also allow a custom name of the item since we're serializing data anyway.

Storage Solutions;

For 1.14+, PersistentDataContainer is the ideal solution. Simple and we don't need reflection.

For below 1.14 the idea is to literally just copy paste the way PersistentDataContainer serializes to NBT

JRoy avatar Apr 14 '21 18:04 JRoy