Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard

Minecraft default join message is not translated

Open jd07159 opened this issue 9 months ago • 4 comments

Type of bug

Other unexpected behaviour

/ess dump all output

Error log (if applicable)

No response

Bug description

The quit message is translated, but the join message is not.

Steps to reproduce

custom-join-message: "none" custom-quit-message: "none"

Expected behaviour

join messages must be translated.

Actual behaviour

The quit message is translated, but the join message is not.

Additional Information

javaw_WPs3wSoiFB

jd07159 avatar May 09 '24 08:05 jd07159

Hey, I was about to open a bug report myself, but then I saw this.

Join messags are always english & the leave message always uses the players local. image

I have been able to determine what is causing this error - allow-silent-join-quit: true - generates these incorrect join/leave messages. [Join message is always english & leave message is players local] If I set it to false, the messages are only in the player's local, as they are supposed to be.

I hope this helps to narrow down the problem.

  • Drei

DreiFxn avatar May 21 '24 07:05 DreiFxn

Hi,

Could you provide me your config.yml @DreiFxn or @jd07159, please? I'd like to replicate your issue. Took a quick look at the code, looks like a pretty simple fix but just want to test it out. Then I can submit a PR.

zp4rker avatar Jun 27 '24 01:06 zp4rker

Set allow-silent-join-quit: true and Setting custom-join-message: "none" will allow you to reproduce the bug. @zp4rker

jd07159 avatar Jun 27 '24 04:06 jd07159

Thanks. I've replicated the bug. Will try working on a solution.

zp4rker avatar Jun 27 '24 11:06 zp4rker