Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard
verified publisher icon EssentialsX

Fix broken legacy to mini conversion

Open pop4959 opened this issue 1 year ago • 3 comments

Fixes #5652 (and probably numerous other issues...)

image

pop4959 avatar Feb 24 '24 05:02 pop4959

Good news and bad news: It fixes the obfuscated formatting in the player's prefix, but broke the rest of the /whois output (God mode and below).

Testing with Paper version git-Paper-435 (MC: 1.20.4)

Before PR (using latest dev build Essentials v2.21.0-dev+56-1929d41):

image

After PR (using Essentials v2.21.0-dev+57-a81725b):

image

Bobcat00 avatar Feb 24 '24 11:02 Bobcat00

Fixing specific incorrect formatting in /whois is probably more sensible to have as a separate PR after this is merged.

mdcfe avatar Feb 24 '24 20:02 mdcfe

fixed the parsed placeholder bug (this was caused by going through the ser/deser process which escapes the output - this is already injection proof so we just need to make sure not to do this for parsed placeholders

new before/after: 566c81ef-6658-40ae-bb65-569b5d3d09f1 a3627ddd-bf61-47ac-9530-142c8edce0cb

pop4959 avatar Feb 25 '24 09:02 pop4959

This looks OK to me. Tested with Paper version git-Paper-435 (MC: 1.20.4) and Essentials v2.21.0-dev+62-5216246. Tested commands /list, /whois, /seen, /msg, and /me.

Bobcat00 avatar Feb 25 '24 12:02 Bobcat00