Essentials
Essentials copied to clipboard
EssentialsX
Add support for Folia
this barely works
todo;
- [ ] validate timer race conditions
- [ ] fix the tps command shit
- [ ] InteractionControllerImpl commands don't fucking fire, need to figure out what im going to do, need to delegate threads for commands to run OUTside of the jda event but also get some of that off netty threads
- [ ] review everything ran on global thread
- [ ] entire discord module probably doesn't work
- [ ] finish static accesses to the scheduler
- [ ] what are we doing with api events
there is a problem with essentialsSpawn folia respawn-listener is not working no matter how i tune
respawn-listener-priority: high
spawn-join-listener-priority: high
respawn-at-home: false
respawn-at-home-bed: true
player die will not go back to essentials spawn point if no vanilla spawnpoint, bed and home is set
this does not happen in paper/spigot
This PR runs well on folia 1.20.1 for me.
The only minor issue I've encountered so far is the time and weather setting commands give an error:
The vanilla command (/minecraft:time set day) work fine so this is really minor.
The time and weather commands now show a success message but doesn't seem to actually have an effect on the time/weather.
[17:46:45] [Region Scheduler Thread #1/INFO]: iLemon issued server command: /time night
[17:46:45] [Region Scheduler Thread #1/WARN]: [Essentials] Location task for Essentials v2.20.1-dev+67-0c8bc16 in world CraftWorld{name=world} at 0, 0 generated an exception
java.lang.IllegalStateException: Cannot modify time off of the global region
at io.papermc.paper.threadedregions.RegionizedServer.ensureGlobalTickThread(RegionizedServer.java:106) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at org.bukkit.craftbukkit.v1_20_R1.CraftWorld.setTime(CraftWorld.java:858) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at com.earth2me.essentials.commands.Commandtime.lambda$run$0(Commandtime.java:92) ~[EssentialsX-2.20.1-dev+67-0c8bc16.jar:?]
at io.papermc.paper.threadedregions.scheduler.FoliaRegionScheduler.lambda$wrap$0(FoliaRegionScheduler.java:35) ~[folia-1.20.1.jar:?]
at io.papermc.paper.threadedregions.RegionizedTaskQueue$PrioritisedQueue$ChunkBasedPriorityTask.executeInternal(RegionizedTaskQueue.java:504) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at io.papermc.paper.threadedregions.RegionizedTaskQueue$PrioritisedQueue.executeTask(RegionizedTaskQueue.java:434) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at io.papermc.paper.threadedregions.RegionizedTaskQueue$RegionTaskQueueData.drainTasks(RegionizedTaskQueue.java:263) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1514) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:360) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:385) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Everything works fine except the respawn feature (tested from the previous comment to see if it was still an issue)
No issues on my end after testing it on prod, would love to see a merge to the main branch
[Essentials] Dispatching command async kits: newplayer: delay: -1 items: - eco give {USERNAME} 10
Small issue with commands in kits, I'm getting the error "[22:57:44 WARN]: [Essentials] Dispatching command async" and that's it and I won't receive the items executed thru a command
