EssentialsX
PR Closing #2057 - mail clearall and mail clear [player]
Information
This PR closes #2057.
Details
Proposed feature:
/mail clear [player] and /mail clearall. Functions on online and offline players, and clears their mailboxes. Adds permissions essentials.mail.clear.others and essentials.mail.clearall.
Note; please look closely at my code. This is one of my first times working on a GitHub project, so I want to be sure I'm not breaking anything and that I'm doing it right.
Environments tested:
OS: Windows 11
Java version: Java(TM) SE Runtime Environment (build 17.0.1+12-LTS-39)
- [ ] Most recent Paper version (1.XX.Y, git-Paper-BUILD)
- [x] CraftBukkit/Spigot/Paper 1.18.2
- [ ] CraftBukkit 1.8.8
Demonstration:
Before /mail clearall:
After /mail clearall:
Before /mail clear [player]:
After /mail clear [player]:
I'm sorry, I'm still kind of new to GitHub. Is there something I need to do to get this approved?
I'm sorry, I'm still kind of new to GitHub. Is there something I need to do to get this approved?
We haven't had the time to review this PR yet. Once the 1.19 update is finished, we'll start reviewing PRs that add new features.
Alright, I believe I did what you asked. To make it easier to display the user the clear command was used on, I set the clearMail() command to return that User object so I can include their name in the message.
Thought I'd give this a poke. Not sure if I have to do anything from here.