Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard
verified publisher icon EssentialsX

We're going on an Adventure!

Open JRoy opened this issue 3 years ago • 2 comments

https://user-images.githubusercontent.com/10731363/147530817-f9adc58e-18a5-49ed-84c6-106e51d6948f.mp4

Closes #2029 Closes #2391

Todo

  • [x] Per Player Locale
    • [x] Add support for them
    • [x] Finish porting everything over to per-player-locale system.
  • [x] MiniMessage Support (Components - Hover/Click Events)
    • No messages will be converted to MiniMessage in this PR, a separate PR will add this.
    • Currently, there are a few messages which are a giant pain in the ass to convert to support components. They will be converted on a need-to basis.

JRoy avatar Dec 28 '21 05:12 JRoy

Per player locale and MiniMessage support has been completed and this pull request is now ready for review :)

JRoy avatar Dec 30 '21 16:12 JRoy

TODO minimessage support for mails. Gonna need to move the mail line logic out of the service (or change its behavior :/)

JRoy avatar Jul 22 '22 18:07 JRoy

I'm praying for your sanity man

LcyDev avatar Jan 08 '23 20:01 LcyDev

LGTM

codebycam avatar Jan 27 '23 12:01 codebycam

Build failed?

Potothingi avatar Sep 26 '23 13:09 Potothingi

Build failed?

yes, they will fail until all translation strings are converted to mini message. this will be done right before merging

JRoy avatar Sep 26 '23 16:09 JRoy

Hello, is there any news on this or something we could do to help you ?

PapiCapi avatar Oct 29 '23 10:10 PapiCapi

Hello, is there any news on this or something we could do to help you ?

we're working on finalizing translations and documentation, The code is pretty much complete at this point

JRoy avatar Oct 29 '23 11:10 JRoy

Just your friendly neighborhood server admin, I was wondering if we could get a progress report of some kind. I really appreciate yall's work, and also had a few questions regarding these changes that the answers to are probably well-known to EssentialsX developers, but I have not been able find answers to elsewhere:

  • Does this PR add PlaceholderAPI Support? (as #2041 started, then was closed in favor of #2502, which was closed in favor of this PR)
  • Does this PR add MiniPlaceholder support?
  • Would the {PLACEHOLDER} style placeholders in configs and *.txt files need to be modified?

I don't want to be a nag, but I really do appreciate your work and would like to know how this all is going so far, thank you all very much!

TheKrafter avatar Nov 24 '23 04:11 TheKrafter

LGTM

Still LGTM

codebycam avatar Jan 27 '24 00:01 codebycam

When a player joins the server, an error is sent: https://pastes.dev/YbBHLlf2fw When trying to receive messages from Essentials an error is sent: https://pastes.dev/lB3llBOiDM

image

SrBedrock avatar Feb 03 '24 19:02 SrBedrock

When a player joins the server, an error is sent: https://pastes.dev/YbBHLlf2fw When trying to receive messages from Essentials an error is sent: https://pastes.dev/lB3llBOiDM

image

Any chance you were live swapping the EssX jar in the plugins folder instead of using plugins/update ?

mbax avatar Feb 03 '24 20:02 mbax

@SrBedrock The PR has been updated to shade the missing options library - would you be able to update to the latest dev build?

mdcfe avatar Feb 03 '24 20:02 mdcfe