UniversalCraft icon indicating copy to clipboard operation
UniversalCraft copied to clipboard

FMLModType included in fabric jars

Open ThatGravyBoat opened this issue 9 months ago • 0 comments

The FMLModType manifest entry is included in fabric jars which causes issues with things like Sinytra Connector.

https://github.com/EssentialGG/UniversalCraft/blob/d0ab6220383c843c3e294d94671d96ed38f11ce2/build.gradle.kts#L30

In addition FMLModType is LIBRARY when in modern versions it should be GAMELIBRARY as LIBRARY is meant for plugin layers while GAMELIBRARY is meant for mods/code that references minecraft code in the game layer

  • Forge: https://github.com/MinecraftForge/ForgeSPI/blob/master/src/main/java/net/minecraftforge/forgespi/locating/IModFile.java#L141
  • NeoForge: https://github.com/neoforged/FancyModLoader/blob/main/loader/src/main/java/net/neoforged/neoforgespi/locating/IModFile.java#L180

ThatGravyBoat avatar May 02 '24 16:05 ThatGravyBoat