solutions-geoprocessing-toolbox icon indicating copy to clipboard operation
solutions-geoprocessing-toolbox copied to clipboard

Distance To Assets.tbx needs unit tests written.

Open ACueva opened this issue 7 years ago • 5 comments

Distance to Assets.tbx currently has no unit tests written.

Minimum Requirements:

Confidence that after unit tests are run that the toolbox works as expected. Tests Will need to be written to both run against ArcMap and ArcGIS Pro.

Max Requirements:

Ask yourself, "Am I writing tests for the sake of writing tests?". If they provided little to no value, please don't write one.

Main Focus:

Focus tests on workflows customers would use. If additional instructions on workflows are needed please refer to the solutions pages: http://solutions.arcgis.com/defense/help/distance-to-assets/

Tests needed:

  • [ ] Geocode Assets and Bases
  • [ ] Copy Geocoded Locations
  • [ ] Route from Assets to Bases Local Network
  • [ ] Route from Assets to Bases ArcGIS Online
  • [ ] Summarize Results

ACueva avatar Jul 27 '17 18:07 ACueva

FYI @lfunkhouser @mfunk

ACueva avatar Jul 27 '17 18:07 ACueva

Note: issue depends on / related to #522 (add toolbox to repo)

csmoore avatar Jul 27 '17 18:07 csmoore

This toolbox contains no custom python code, it purely utilises out of the box tools, are we in danger here that we are writing test scripts that check that core tools work correctly?

adgiles avatar Jul 31 '17 17:07 adgiles

@pHill5136 Got this started in https://github.com/Esri/solutions-geoprocessing-toolbox/tree/dev/utils/test/distance_to_assets_tests Will reassign items in here and Asana to you per our discussion this morning.

mfunk avatar Aug 07 '17 15:08 mfunk

@mfunk do we know what the status of these tests are, I see that they are in the dev branch here:

https://github.com/Esri/solutions-geoprocessing-toolbox/tree/dev/utils/test/distance_to_assets_tests

can we close this issue out?

adgiles avatar Dec 08 '17 13:12 adgiles