esri-leaflet-vector icon indicating copy to clipboard operation
esri-leaflet-vector copied to clipboard
verified publisher icon Esri

Update to MapLibre GL JS v5.0

Open gavinr-maps opened this issue 1 year ago • 2 comments

Describe the problem

v5.0 was released recently: https://github.com/maplibre/maplibre-gl-js/releases/tag/v5.0.0 (https://github.com/maplibre/maplibre-gl-js/pull/5272)

Describe the proposed solution

  1. Test using v5 with Esri Leaflet Vector
  2. If all tests pass, include v5 as packaged in the next release. See here for an example of the expected package.json changes: https://github.com/Esri/esri-leaflet-vector/pull/219/files

Alternatives considered

No response

Additional Information

Note: possibly look into this issue at the same time: https://github.com/Esri/esri-leaflet-vector/issues/152

gavinr-maps avatar Jan 02 '25 16:01 gavinr-maps

I've started the process here: #232. I'm getting errors on startup and when I try to pan:

  • Startup: MaplibreGLLayer.js:187 Uncaught TypeError: Cannot set property latRange of #<Dt> which has only a getter
  • Pan: MaplibreGLLayer.js:254 Uncaught TypeError: Cannot set property center of #<Dt> which has only a getter

... which seems to be consistent with this error that is an issue in maplibre-gl-leaflet: https://github.com/maplibre/maplibre-gl-leaflet/issues/64.

gavinr-maps avatar Jan 02 '25 18:01 gavinr-maps

Next step on this one: we should pull over the changes from https://github.com/maplibre/maplibre-gl-leaflet/pull/82 into esri-leaflet-vector. We hope doing that will resolve this issue.

gavinr-maps avatar Aug 19 '25 16:08 gavinr-maps