fix(list-item): Always reserve spacing for open icon

[driskull]

Related Issue: #8667

Summary

• Always reserve space for open toggle icon
• Screenshot tests show changes

[ashetland]

I just noticed that the "Nested List" page isn't expanded in the baseline or new so chromatic isn't picking up the changes. It might be worth expanding all the items in that page so we have it as a baseline.

[ashetland]

Also the baseline is showing the old icons?

[driskull]

I think those icons are slotted in, not in the component

[driskull]

@ashetland is this one good to merge?

[ashetland]

Sadly no. We got feedback that folks aren't super happy about the added space in a flat list scenario. I'm drawing up specs for revised spacing in both flat and nested lists as there was a strong desire for this to be configurable. We'll need to push implementation to March. cc @jcfranco

[driskull]

there was a strong desire for this to be configurable

I think that would be a breaking change if we required people to configure allowing nesting and doesn't seem very user friendly to have to do.

If the reserved space for a nesting icon is an issue maybe it should be moved to the opposite side like the block/accordion components?

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.