calcite-design-system icon indicating copy to clipboard operation
calcite-design-system copied to clipboard

Split Button - consistent divider across appearances

Open ashetland opened this issue 1 year ago • 3 comments

Check existing issues

Description

The vertical divider in Split Button should visually match across appearance values.

Acceptance Criteria

See Figma file. outline and outline-fill are updated to match solid and transparent. CleanShot 2023-11-07 at 14 02 58@2x

Relevant Info

cc @jcfranco

Which Component

Split Button

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • [X] @esri/calcite-components
  • [ ] @esri/calcite-components-react
  • [ ] @esri/calcite-design-tokens
  • [ ] @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

ashetland avatar Nov 07 '23 22:11 ashetland

cc @geospatialem, @brittneytewks

github-actions[bot] avatar Nov 07 '23 22:11 github-actions[bot]

Added visual changes label as this will tweak the outline-fill divider.

jcfranco avatar May 09 '24 21:05 jcfranco

Installed and assigned for verification.

github-actions[bot] avatar May 14 '24 02:05 github-actions[bot]

In verifying in 2.9.0-next.18 it looks like if a background color is added, the same color is placed in the empty space for the revised divider: https://codepen.io/geospatialem/pen/VwOjjOX

image

@josercarcamo reassigning back to ya and set to in development for further investigation. 🕵🏻

geospatialem avatar May 22 '24 17:05 geospatialem

Installed and assigned for verification.

github-actions[bot] avatar May 23 '24 21:05 github-actions[bot]

Verified in 2.9.0-next.21 with https://codepen.io/geospatialem/pen/VwOjjOX 🎉

image

geospatialem avatar May 23 '24 22:05 geospatialem