calcite-design-system icon indicating copy to clipboard operation
calcite-design-system copied to clipboard

[calcite-color] add support for alpha

Open jcfranco opened this issue 4 years ago • 18 comments

The color picker needs to support alpha channel updates. https://github.com/Esri/calcite-components/issues/64#issuecomment-583678167 has some designs with opacity.

Not sure if the design needs any tweaks, but it'd be nice for the final design to have an alpha channel input as well. The color picker from Chrome dev tool's has something similar:

cdt-cp-colors

jcfranco avatar Jul 22 '20 15:07 jcfranco

👀

bstifle avatar Jul 22 '20 17:07 bstifle

Another thing to consider in the design is the selected color + transparency preview. One idea would be to update calcite-color-swatch to support transparency (rough mockup 😄):

Screen Shot 2020-07-29 at 1 31 12 PM

jcfranco avatar Jul 29 '20 20:07 jcfranco

yeah i dig it

bstifle avatar Jul 29 '20 21:07 bstifle

Yeah looks good... Think that's a pretty universal treatment for opacity so should be familiar.

macandcheese avatar Jul 29 '20 21:07 macandcheese

image here's a comp with the transparency checker fill.

light theme using 4x4 #000000 squares at 40% opacity dark theme using 4x4 #FFFFFF squares at 40% opacity

bstifle avatar Jul 29 '20 22:07 bstifle

image ok this is better.

#CACACA for light theme #6A6A6A for dark

bstifle avatar Jul 29 '20 23:07 bstifle

Is there any progress on this one? Testers for charts keep running into it and noticing they can't control this.

smambrose avatar Mar 05 '21 20:03 smambrose

@smambrose Not for the time being. I'll move this to backlog until it's ready for development. I estimate this will land after 1.0.0 ships (after April).

jcfranco avatar Mar 05 '21 21:03 jcfranco

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 05 '21 01:04 github-actions[bot]

Having the ability to change the Opacity would be a great enhancement for our team as well. An example of a use case for us:

image

tyanthony avatar Jun 30 '21 16:06 tyanthony

@bstifle, is this one ready for implementation?

julio8a avatar Jul 29 '21 21:07 julio8a

Here's the design with an opacity slider:

image

bstifle avatar Aug 06 '21 23:08 bstifle

Moving to next sprint. Draft PR should be up today.

jcfranco avatar Aug 16 '21 21:08 jcfranco

Moving to a future sprint (current one is a low-risk sprint). This should land this week. I've got some review feedback to address and tests to add.

dog-so-close

jcfranco avatar Aug 31 '21 00:08 jcfranco

Hey @jcfranco, was there just a little bit left to do on this? Checking on if it could be for this release cycle, thanks!!

ethanbdev avatar Dec 21 '21 20:12 ethanbdev

Any update on this?

phlorah avatar Mar 16 '22 22:03 phlorah

Apologies for the belated update. I have an old PR with the functionality in place, but no tests set up. I'll sync it with the latest changes and add the missing tests for the assigned milestone.

jcfranco avatar Mar 18 '22 23:03 jcfranco

Quick update: while adding/updating the remaining tests, there were some additional changes that went in that I'd like to test a bit more before we ship. Based on this, I'm moving it to the next release. Worth noting that this will land early in the next sprint and will be available under @next.

jcfranco avatar Apr 12 '22 17:04 jcfranco

Updated designs complete. @geospatialem @brittneyzwolfer for visibility. @jcfranco added to Figma file.

ashetland avatar Nov 03 '22 23:11 ashetland

Is there any expected release date for this? We are waiting on support for alpha and RGBA before migrating Vector Tile Style Editor to this.

patrickarlt avatar Dec 08 '22 23:12 patrickarlt

@geospatialem Not sure if Franco started work on this before he went on leave.

ashetland avatar Dec 08 '22 23:12 ashetland

We plan on installing the functionality for v1, however it will go through a design rework afterwards at some point. The design rework would impact layout so it would be a breaking change. Here is a demo with the existing functionality if you want to take a look (VPN required)

benelan avatar Dec 09 '22 00:12 benelan

Here is a publicly accessible link to the existing calcite-color-picker alpha functionality

benelan avatar Dec 09 '22 00:12 benelan

Will continue efforts in February's priorities.

geospatialem avatar Jan 25 '23 21:01 geospatialem

Updated designs are available as well.

ashetland avatar Jan 31 '23 19:01 ashetland

Update: this will land this week, but will be available via next and not in the April release. Automated tests will be updated/added separately.

jcfranco avatar Apr 24 '23 17:04 jcfranco

Installed and assigned for verification.

github-actions[bot] avatar May 03 '23 02:05 github-actions[bot]

Verified in 1.4.0-next.6 with the alpha-channel attribute:

<calcite-color-picker alpha-channel></calcite-color-picker>

image

geospatialem avatar May 03 '23 16:05 geospatialem

Adding to the new future breaking change label, where a few deprecated props take place:

  • hideChannels
  • hideHex
  • hideSaved

geospatialem avatar May 04 '23 13:05 geospatialem