calcite-design-system icon indicating copy to clipboard operation
calcite-design-system copied to clipboard

Epic: Updates to Color Picker

Open ashetland opened this issue 1 year ago • 4 comments

Description

The design phase for adding alpha channel support to Color Picker (issue #749) proposed additional improvements that were intended to be tackled after the initial alpha channel support was implemented. This issue is to document the remaining tasks to complete. cc: @fr

Acceptance Criteria

  • [x] https://github.com/Esri/calcite-design-system/issues/9412
  • [ ] https://github.com/Esri/calcite-design-system/issues/9413
    • Update the internal borders inside channels input to be border-3.
  • [ ] https://github.com/Esri/calcite-design-system/issues/9415
  • [ ] https://github.com/Esri/calcite-design-system/issues/9414

Relevant Info

For full details, updated Figma file can be found here.

Historical screenshots of first pass on design below. Updated mocks are available in the associated issues above. image image image image

Which Component

Color Picker

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Esri team

Calcite (design)

ashetland avatar Jun 12 '23 19:06 ashetland

@macandcheese @SkyeSeitz The above comment has been updated to reflect the changes we discussed.

ashetland avatar Jun 20 '23 23:06 ashetland

Note, the square color field above should have the lowest priority. Will need feedback from teams as it may have adverse affects on layouts.

ashetland avatar Aug 08 '23 16:08 ashetland

Maybe a way for users to customize height of color graph? The square ones end up being significantly “taller” than previously - perhaps height graph prop for S/M/L? I think using css vars not possible with the color graph.

The previous heights are probably more expected, having it square just adds “more granular choice” to the graph but not sure that is actually needed.

macandcheese avatar Aug 08 '23 16:08 macandcheese

Yeah I could see that working well.

ashetland avatar Aug 08 '23 16:08 ashetland