EZSwiftExtensions icon indicating copy to clipboard operation
EZSwiftExtensions copied to clipboard

Updated to the Swift4.2(Xcode10 beta6)

Open shanyanhai opened this issue 6 years ago • 8 comments

in code: Fix Any warning Fix emoji judge Known issues : traverse enum is failure in Test : String does not belong to NSObject and does not have the classname attribute.(location: testClassName)

testClassName

Checklist

  • [ ] New Extension
  • [ ] New Test
  • [ ] Changed more than one extension, but all changes are related
  • [x] Trivial change (doesn't require changelog)

shanyanhai avatar Sep 03 '18 08:09 shanyanhai

5 Errors
:no_entry_sign: Please, modify only one extension per pull request.
:no_entry_sign: Sources/EZSwiftFunctions.swift#L81: unexpected platform condition (expected ‘os’, ‘arch’, or ‘swift’)
#if targetEnvironment(simulator)
:no_entry_sign: Sources/EZSwiftFunctions.swift#L90: unexpected platform condition (expected ‘os’, ‘arch’, or ‘swift’)
#if targetEnvironment(simulator)
:no_entry_sign: Sources/ArrayExtensions.swift#L26: cannot convert value of type ‘CountableRange<Array.Index>’ (aka ‘CountableRange<Int>’) to expected argument type ‘Range<Int>’
let halfOpenClampedRange = Range(range).clamped(to: indices)
:no_entry_sign: Sources/ArrayExtensions.swift#L117: value of type ‘EnumeratedSequence<[Element]>’ has no member ‘compactMap’
return enumerated().compactMap { ($0.element == element) ? $0.offset : nil }

Generated by :no_entry_sign: Danger

EZSwiftExtensionsBot avatar Sep 03 '18 08:09 EZSwiftExtensionsBot

Please use the Xcode Version 10.0, supporter Swift 4.2. No major logical changes,Swift4.2:Many enums class names have been changed, if modify only one extension per pull request.Time consuming.

shanyanhai avatar Sep 03 '18 08:09 shanyanhai

@shanyanhai
Hi there, Is there any way to pod your updated branch to my project?

ceeyang avatar Sep 28 '18 01:09 ceeyang

@shanyanhai Hi there, Is there any way to pod your updated branch to my project? pod 'EZSwiftExtensions', :git => 'https://github.com/shanyanhai/EZSwiftExtensions.git', :branch => 'Swift4.2'

shanyanhai avatar Sep 28 '18 01:09 shanyanhai

@shanyanhai You should update travis configuration to specify Xcode version. And maybe Xcode 10 GM is a better choice rather than a beta version.

isimple4 avatar Sep 28 '18 01:09 isimple4

@shanyanhai Thanks very much. You did me a big favor.

ceeyang avatar Sep 28 '18 01:09 ceeyang

@shanyanhai Thanks very much. You did me a big favor.

Xcode (10A254a) ---OK , I'm using. I don't know how to update Travis configuration /:wipe

shanyanhai avatar Sep 28 '18 02:09 shanyanhai

Cross check the official effort here : https://github.com/goktugyil/EZSwiftExtensions/pull/496. I think I covered all your changes here and made further progress on this.

Khalian avatar Nov 12 '18 08:11 Khalian