EZSwiftExtensions icon indicating copy to clipboard operation
EZSwiftExtensions copied to clipboard

Minor crash resolved

Open ioskunal opened this issue 6 years ago • 4 comments

invalid check mistake resolved

Checklist

  • [ ] New Extension
  • [ ] New Test
  • [ ] Changed more than one extension, but all changes are related
  • [ ] Trivial change (doesn't require changelog)

ioskunal avatar Mar 22 '18 19:03 ioskunal

Thanks for the PR. Is there an associated test with this? Did it run before? Does it run now?

Esqarrouth avatar Mar 22 '18 19:03 Esqarrouth

Thanks for quick reply. I tested this manually. The loop has to be executed from 0 to n-1 where as it runs from 0 to n and then it crashes at n index. I had checked this and now it works fine.

ioskunal avatar Mar 22 '18 19:03 ioskunal

1 Error
:no_entry_sign: Making non-trivial change requires changelog entry! Please, set trivial change or add entry to changelog.
2 Messages
:book: Executed 203 tests, with 0 failures (0 unexpected) in 6.527 (6.789) seconds
:book: Executed 125 tests, with 0 failures (0 unexpected) in 4.777 (4.869) seconds

Generated by :no_entry_sign: Danger

EZSwiftExtensionsBot avatar Mar 22 '18 20:03 EZSwiftExtensionsBot

Could you edit the test cases here so it gives an asset while running the code:

for i in 0...length {

But doesn't give an assert with:

for i in 0..<length {

https://github.com/goktugyil/EZSwiftExtensions/blob/master/EZSwiftExtensionsTests/StringTests.swift

Esqarrouth avatar Mar 22 '18 20:03 Esqarrouth