espresso-sequencer icon indicating copy to clipboard operation
espresso-sequencer copied to clipboard

I08: Incomplete test coverage of library functions

Open philippecamacho opened this issue 1 year ago • 1 comments

Affected Code: • BN254.sol (lines 83,91,100,108,113,135) • BN254.sol (lines 140,145,150,173,188,234) • BN254.sol (lines 313,331)

Summary: Several functions (infinity, isInfinity, negate, add, mul, multiScalarMul, invert, validateScalarField, g1Serialize, g1Deserialize) in the library lack sufficient test coverage. Although the current implementation is correct, making changes to the library might result in unexpected behavior.

Suggestion: Write unit tests for all the functions to ensure the library’s correctness and ease of maintenance.

philippecamacho avatar Jul 18 '24 15:07 philippecamacho