espresso-sequencer icon indicating copy to clipboard operation
espresso-sequencer copied to clipboard

Don't turn on `testing` feature for non-test builds

Open sveitser opened this issue 1 year ago • 2 comments

Need to at least remove features = ["testing"] from sequencer = { path = "../sequencer", features = ["testing"] } from the non-dev dependencies of builder. Then there are some compilation errors to fix because we have accidentally started to rely on the accidentally turned on "testing" feature.

Should be easier to fix when

  • https://github.com/EspressoSystems/espresso-sequencer/pull/1467

Is done because it will remove the call to NodeState::mock() which requires the "testing" feature.

sveitser avatar May 21 '24 15:05 sveitser

error[E0599]: no function or associated item named `mock` found for struct `NodeState` in the current scope
   --> sequencer/src/block.rs:76:49
    |
76  |         Self::from_transactions([], &NodeState::mock()).unwrap()
    |                                                 ^^^^ function or associated item not found in `NodeState`

removing testing feature from builder results in this error. https://github.com/EspressoSystems/espresso-sequencer/pull/1467

imabdulbasit avatar May 21 '24 15:05 imabdulbasit

default implementation of NodeState requires the testing feature because it includes MockStateCatchup, which is only available in the testing feature.

imabdulbasit avatar Jul 19 '24 14:07 imabdulbasit