HotShot icon indicating copy to clipboard operation
HotShot copied to clipboard

HotShot logging for better debugging experience

Open pls148 opened this issue 11 months ago • 0 comments

Salman Zulip

  • I think we should log the last view we received a (valid) vote from each node. We can add a field to VoteCollectorsMap to store this internally as a BTreeMap<stake table entry/public key, u64> in VoteCollectionTaskState (?), and update it when handling votes. might not even have to store the view, it coudl be a simple counter that we reset whenever we get a vote and increment when we produce a cert without that node's vote

    whenever we produce a cert we can print nodes that haven't sent us a vote e.g. >10 times in a row

  • we should also find some way to log unsatisfied dependencies when we fail to vote/propose, so we can easily tell from the logs what we were missing. I think this log should print whenever we cancel a vote/propose task for an older view, or when we send a timeout vote

pls148 avatar Dec 12 '24 19:12 pls148