HotShot
HotShot copied to clipboard
[CX_CLEANUP] - Diverge the Quorum Vote Task
Closes #3172. Currently a draft, because it's based on https://github.com/EspressoSystems/HotShot/pull/3156. Will rebase after that PR is merged.
This PR:
- Adds the
ValidatedState
dependency to the quorum vote task. - Refactors the
update_state_and_vote_if_able
function:- Adds the dependency-task-related logic to the vote task.
- Only uses it in non-dependency tasks.
- Updates quorum vote task tests.
- Adds the
ValidatedStateValidted
event to the inputs. - Fixes incorrect view index.
- Adds a test for mismatched inputs.
- Adds the
- Misc:
- Combines
test_helpers.rs
andtask_helpers.rs
intohelpers.rs
. - Renames
create_fake_view_with_leaf_*
functions tobuild_fake_view_with_leaf_*
to be consistent with other names. - Renames
disperse_share
tovid_share
, andVID disperse
toVID share
.
- Combines
This PR does not:
Change other tasks other than the vote task.
Key places to review:
-
crates/task-impls/src/consensus/helpers.rs
. -
crates/task-impls/src/quorum_vote.rs
.