[<TECH_DEBT>] - Add a new VidScheme assoc type to NodeType?

[ggutoski]

What is this task and why do we need to work on it?

Currently we simply hard-code the VID scheme type everywhere. Shall we add a new VidScheme assoc type to NodeType? It would make VID consistent with the design pattern for other types. Maybe some other ergonomics benefits, too. I'm not sure it's worth the trouble though. [zulip]

NodeType is instantiated in the sequencer, so the sequencer would choose the concrete type of VidScheme. But we want hotshot to choose that type. Now, I see that some other node types are actually defined in hotshot (not the sequencer) and yet the sequencer merely sets that hotshot type in its instantiation of NodeType. Examples: Time, SignatureKey, ElectionConfigType, Membership. So I guess it's no problem to add VidScheme to this list...?

What work will need to be done to complete this task?

No response

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

All (or most?) use of VID is done via NodeType.

Branch work will be merged to (if not the default branch)

No response