Labrador icon indicating copy to clipboard operation
Labrador copied to clipboard

[Admin] cleanup old branches

Open mi-hol opened this issue 10 months ago • 4 comments

Image

  1. harvest valuable changes from old branches
  2. delete old branches afterwards

mi-hol avatar Feb 10 '25 18:02 mi-hol

All done! Left Vincenzo's branch just in case there's FFT fixes in there. :)

EspoTek avatar Feb 12 '25 08:02 EspoTek

@EspoTek WoW! That was quick! Very much appreciated!

mi-hol avatar Feb 12 '25 11:02 mi-hol

reopened to not forget about outstanding work for branch "vincenzo1207"

mi-hol avatar Feb 12 '25 11:02 mi-hol

All done! Left Vincenzo's branch just in case there's FFT fixes in there. :)

I'll take care of that and assigned to myself

mi-hol avatar Feb 12 '25 11:02 mi-hol

@espotek-org/maintainers it seems Vincenzo-Petrolo added DFT (described in https://github.com/kfrlib/kfr?tab=readme-ov-file#fftdft) in this branch

I have unfortunately no clue if that is beneficial for Labrador, therefore I'd like to ask one of you to step in please. Any volunteer?

mi-hol avatar Apr 05 '25 20:04 mi-hol

I don't know how you connected Vincenzo-Petrolo with the kfr project, but Vincenzo implemented the DFT using fftw3 library which is not used in the kfr project.

Anyhow, I have once looked at the changes in his branch and all of them appear to be in master.

Nevertheless, we can reach him out for the final verdict, which I believe will be to delete the branch.

mmehari avatar Apr 05 '25 21:04 mmehari

I don't know how you connected Vincenzo-Petrolo with the kfr project, but Vincenzo implemented the DFT using fftw3 library which is not used in the kfr project.

It seemed to be linked to kfr because of the added dependency to "url = https://github.com/kfrlib/kfr.git" in https://github.com/espotek-org/Labrador/commit/2dc723dc9a8a7163be96f71f0d7267eb62fdc815 but my limited understanding of these technical details is the reason to aks for your help :)

Nevertheless, we can reach him out for the final verdict

I reached out to Vincenzo already but he responded with "busy with other stuff".

Are we in agreement to delete his branch ? Please comment with a yes/no/not sure type response

mi-hol avatar Apr 06 '25 11:04 mi-hol

Yes, we can delete it

mmehari avatar Apr 06 '25 14:04 mmehari

I agree we can delete it.

turboencabulator avatar Apr 06 '25 17:04 turboencabulator

@mmehari @turboencabulator Thanks for your help! Branch was deleted

mi-hol avatar Apr 06 '25 18:04 mi-hol