kryonet icon indicating copy to clipboard operation
kryonet copied to clipboard

Published 20 hours ago • verified publisher icon EsotericSoftware

Few critical bugs are fixed

Open georgemavchun opened this issue 9 years ago • 5 comments

Few bug fixes included. In each commit there is test that fails without fix commit and doesn't fail with it.

georgemavchun avatar Jun 18 '15 12:06 georgemavchun

Combining multiple fixes in the same PR makes review difficult. Please explain the fixes.

NathanSweet avatar Jun 29 '15 16:06 NathanSweet

Should we delete that PR and resubmit few new? Or comments we have written is enough?

georgemavchun avatar Jul 02 '15 13:07 georgemavchun

So what should we do now?

georgemavchun avatar Jul 07 '15 10:07 georgemavchun

@NathanSweet Any news on this?

CreamyCookie avatar Jul 07 '16 13:07 CreamyCookie

Splitting it into multiple PRs would help a lot.

NathanSweet avatar Jul 03 '18 13:07 NathanSweet