kryonet icon indicating copy to clipboard operation
kryonet copied to clipboard

Client connect timeout not being used

Open m6246 opened this issue 8 years ago • 3 comments

Client.connect accepts a timeout parameter which is stored so Client.reconnect will use that, however within Client.connect at line 175, tcp.connect uses a hard-coded timeout value of 5000 where the timeout parameter should be used.

m6246 avatar Oct 10 '15 23:10 m6246

@m6246 have you tried changing it to the timeout value and seeing if it works? You could submit a PR for that.

payne911 avatar Jun 12 '20 16:06 payne911

As #connect is just calling Socket#connect this should most definitely work.

Strangely, the timeout is used for reconnecting, see here.

crykn avatar Jun 13 '20 17:06 crykn

Indeed, that is strange.

payne911 avatar Jun 13 '20 19:06 payne911