gl-catmull-clark icon indicating copy to clipboard operation
gl-catmull-clark copied to clipboard

convertToTriangles documentation is confusing

Open gregtatum opened this issue 7 years ago • 2 comments

For what it's worth, I found it very confusing that convertToTriangles was true by default. I spent a good half an hour debugging my code before I realized that. I think a less confusing function signature would be function catmullClark(positions, cells, numSubdivisions[, keepAsQuads]). I assumed incorrectly that undefined would be falsey.

gregtatum avatar Jan 24 '17 03:01 gregtatum

Yeah, sorry about that. I will try to look at this in the weekend.

Erkaman avatar Jan 24 '17 05:01 Erkaman

No worries, it worked like a charm once I figured it out! Thanks for publishing this module, it's really handy: http://sessions.gregtatum.com/013/

gregtatum avatar Jan 24 '17 13:01 gregtatum